netdev - Re: [net-next PATCH V3] octeontx2-pf: Add egress PFC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220825195544.391577b2@kernel.org>
Date:   Thu, 25 Aug 2022 19:55:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Suman Ghosh <sumang@...vell.com>
Cc:     <sgoutham@...vell.com>, <lcherian@...vell.com>,
        <gakula@...vell.com>, <jerinj@...vell.com>, <hkelam@...vell.com>,
        <sbhatta@...vell.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>
Subject: Re: [net-next PATCH V3] octeontx2-pf: Add egress PFC support

On Thu, 25 Aug 2022 10:12:42 +0530 Suman Ghosh wrote:
> As of now all transmit queues transmit packets out of same scheduler
> queue hierarchy. Due to this PFC frames sent by peer are not handled
> properly, either all transmit queues are backpressured or none.
> To fix this when user enables PFC for a given priority map relavant
> transmit queue to a different scheduler queue hierarcy, so that
> backpressure is applied only to the traffic egressing out of that TXQ.

Does not build at all now:

ERROR: modpost: drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf: 'otx2_pfc_txschq_update' exported twice. Previous export was in drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicpf.ko
ERROR: modpost: "otx2_txschq_config" [drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf.ko] undefined!
ERROR: modpost: "otx2_smq_flush" [drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf.ko] undefined!