netdev - Re: [PATCH net-next v3 2/3] sfc: support PTP over IPv6/UDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4oufi28iXQscAcmrQAuiKa+PRB81-27AC4E7D41LG1uzeAg@mail.gmail.com>
Date:   Fri, 26 Aug 2022 08:39:44 +0200
From:   Íñigo Huguet <ihuguet@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     ecree.xilinx@...il.com, habetsm.xilinx@...il.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/3] sfc: support PTP over IPv6/UDP

On Fri, Aug 26, 2022 at 3:32 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 25 Aug 2022 11:02:41 +0200 Íñigo Huguet wrote:
> > -static int efx_ptp_insert_ipv4_filter(struct efx_nic *efx, u16 port)
> > +static inline void efx_ptp_init_filter(struct efx_nic *efx,
> > +                                    struct efx_filter_spec *rxfilter)
>
> No static inline in sources unless you actually checked and the
> compiler does something stupid (pls mention it in the commit message
> in that case).

OK, I will change it (I think I should read again and remember the
coding style document)

>
> > +static inline int
> > +efx_filter_set_ipv6_local(struct efx_filter_spec *spec, u8 proto,
> > +                       const struct in6_addr *host, __be16 port)
>
> also - unclear why this is defined in the header
>

This is just because it's the equivalent of other already existing
similar functions in that file. I think I should keep this one
untouched for cohesion.
-- 
Íñigo Huguet