netdev - Re: [PATCH 1/2] net: dsa: microchip: add KSZ9896 switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e5ac683-130e-2a00-79c5-b5ec906d41d1@smile.fr>
Date:   Fri, 26 Aug 2022 09:31:00 +0200
From:   Romain Naour <romain.naour@...le.fr>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, woojung.huh@...rochip.com,
        UNGLinuxDriver@...rochip.com, arun.ramadoss@...rochip.com,
        Romain Naour <romain.naour@....com>
Subject: Re: [PATCH 1/2] net: dsa: microchip: add KSZ9896 switch support

Hi,

Le 26/08/2022 à 00:04, Andrew Lunn a écrit :
> On Thu, Aug 25, 2022 at 11:39:42PM +0200, Romain Naour wrote:
>> From: Romain Naour <romain.naour@....com>
>>
>> Add support for the KSZ9896 6-port Gigabit Ethernet Switch to the
>> ksz9477 driver.
>>
>> Although the KSZ9896 is already listed in the device tree binding
>> documentation since a1c0ed24fe9b (dt-bindings: net: dsa: document
>> additional Microchip KSZ9477 family switches) the chip id
>> (0x00989600) is not recognized by ksz_switch_detect() and rejected
>> by the driver.
>>
>> The KSZ9896 is similar to KSZ9897 but has only one configurable
>> MII/RMII/RGMII/GMII cpu port.
>>
>> Signed-off-by: Romain Naour <romain.naour@....com>
>> Signed-off-by: Romain Naour <romain.naour@...le.fr>
> 
> Two signed-off-by from the same person is unusual :-)

Indeed, but my customer (skf) asked me to use the skf.com address for the patch
but I use my smile.fr (my employer) git/email setup for mailing list.

> 
>> ---
>> It seems that the KSZ9896 support has been sent to the kernel netdev
>> mailing list a while ago but got lost after initial review:
>> https://www.spinics.net/lists/netdev/msg554771.html
> 
> I'm not sure saying it got lost is true. It looks more like the issues
> pointed out were never addressed.

It seems the initial KSZ9896 support was in the same patch with other changes
that were addressed later by followup patches.

> 
>> The initial testing with the ksz9896 was done on a 5.10 kernel
>> but due to recent changes in dsa microchip driver it was required
>> to rework this initial version for 6.0-rc2 kernel.
> 
> This looks sufficiently different that i don't think we need
> Tristram's Signed-off-by as well.
> 
> I don't know these chips well enough to do a detailed review.

Thanks for your feedback!

Best regards,
Romain


> 
>   Andrew