lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220826075157.GD2116@pengutronix.de> Date: Fri, 26 Aug 2022 09:51:57 +0200 From: Oleksij Rempel <o.rempel@...gutronix.de> To: Vladimir Oltean <olteanv@...il.com> Cc: Woojung Huh <woojung.huh@...rochip.com>, Andrew Lunn <andrew@...n.ch>, Arun Ramadoss <arun.ramadoss@...rochip.com>, Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Vivien Didelot <vivien.didelot@...il.com>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, kernel@...gutronix.de, Jakub Kicinski <kuba@...nel.org>, UNGLinuxDriver@...rochip.com, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH net-next v3 15/17] net: dsa: microchip: ksz9477: remove unused "on" variable On Thu, Aug 25, 2022 at 11:54:07PM +0300, Vladimir Oltean wrote: > On Tue, Aug 23, 2022 at 10:02:29AM +0200, Oleksij Rempel wrote: > > This variable is not used on ksz9477 side. Remove it. > > > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de> > > --- > > drivers/net/dsa/microchip/ksz9477.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c > > index bfefb60ec91bf..609bd63f4cdb1 100644 > > --- a/drivers/net/dsa/microchip/ksz9477.c > > +++ b/drivers/net/dsa/microchip/ksz9477.c > > @@ -1070,7 +1070,6 @@ void ksz9477_config_cpu_port(struct dsa_switch *ds) > > > > /* enable cpu port */ > > ksz9477_port_setup(dev, i, true); > > - p->on = 1; > > } > > } > > > > @@ -1080,7 +1079,6 @@ void ksz9477_config_cpu_port(struct dsa_switch *ds) > > p = &dev->ports[i]; > > > > ksz_port_stp_state_set(ds, i, BR_STATE_DISABLED); > > - p->on = 1; > > if (dev->chip_id == 0x00947700 && i == 6) { > > p->sgmii = 1; > > } > > -- > > 2.30.2 > > > > And it seems like it's not used on ksz8 either. The reason I'm saying > that is that ksz8_flush_dyn_mac_table() is the only apparent user of > p->on, and that only for the case where flushing the FDB of all ports is > requested (port > dev->info->port_cnt). But ksz8_flush_dyn_mac_table() > (through dev->dev_ops->flush_dyn_mac_table) is only called from DSA's > ds->ops->port_fast_age() method, and that will never be requested > "for all ports" (and to my knowledge never was in the past, either). > Badly ported SDK code would be my guess. So there are more > simplifications which could be done. Ok, i'll take a look on it as soon as i get one of ksz8 board in my fingers. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists