netdev - Re: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220826180134.24b3648a@kernel.org>
Date:   Fri, 26 Aug 2022 18:01:34 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     "Drewek, Wojciech" <wojciech.drewek@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "marcin.szycik@...ux.intel.com" <marcin.szycik@...ux.intel.com>,
        "michal.swiatkowski@...ux.intel.com" 
        <michal.swiatkowski@...ux.intel.com>,
        "kurt@...utronix.de" <kurt@...utronix.de>,
        "boris.sukholitko@...adcom.com" <boris.sukholitko@...adcom.com>,
        "vladbu@...dia.com" <vladbu@...dia.com>,
        "komachi.yoshiki@...il.com" <komachi.yoshiki@...il.com>,
        "paulb@...dia.com" <paulb@...dia.com>,
        "baowen.zheng@...igine.com" <baowen.zheng@...igine.com>,
        "louis.peens@...igine.com" <louis.peens@...igine.com>,
        "simon.horman@...igine.com" <simon.horman@...igine.com>,
        "pablo@...filter.org" <pablo@...filter.org>,
        "maksym.glubokiy@...ision.eu" <maksym.glubokiy@...ision.eu>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "jchapman@...alix.com" <jchapman@...alix.com>,
        "gnault@...hat.com" <gnault@...hat.com>
Subject: Re: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support

On Fri, 26 Aug 2022 16:34:34 +0200 Jiri Pirko wrote:
> >Sorry, I'll include more precise description in the next version.
> >DDP (Dynamic Device Personalization) is a firmware package that contains definitions
> >protocol's headers and packets. It allows you  to add support for the new protocol to the
> >NIC card without rebooting.  If the DDP package does not support L2TPv3 then hw offload 
> >will not work, however sw offload will still work.  
> 
> Hmm, so it is some FW part? Why do we care about it here in patchset
> description?

We generally encourage people to put as much context in the commit
messages and cover letters as possible. Nothing wrong with saying
that a specific parser microcode is needed, IMHO.