netdev - [PATCH net-next] net: sched: red: remove unused input parameter in red_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Aug 2022 12:35:45 +0800
From:   Zhengchao Shao <shaozhengchao@...wei.com>
To:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>
CC:     <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>,
        <shaozhengchao@...wei.com>
Subject: [PATCH net-next] net: sched: red: remove unused input parameter in red_get_flags()

The input parameter supported_mask is unused in red_get_flags().
Remove it.

Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
---
 include/net/red.h   | 1 -
 net/sched/sch_red.c | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/include/net/red.h b/include/net/red.h
index dad41eff8c62..4aed3b2d9725 100644
--- a/include/net/red.h
+++ b/include/net/red.h
@@ -192,7 +192,6 @@ static inline bool red_check_params(u32 qth_min, u32 qth_max, u8 Wlog,
 static inline int red_get_flags(unsigned char qopt_flags,
 				unsigned char historic_mask,
 				struct nlattr *flags_attr,
-				unsigned char supported_mask,
 				struct nla_bitfield32 *p_flags,
 				unsigned char *p_userbits,
 				struct netlink_ext_ack *extack)
diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c
index cae3b80e4d9d..346c6c41ce56 100644
--- a/net/sched/sch_red.c
+++ b/net/sched/sch_red.c
@@ -258,8 +258,8 @@ static int __red_change(struct Qdisc *sch, struct nlattr **tb,
 		return -EINVAL;
 
 	err = red_get_flags(ctl->flags, TC_RED_HISTORIC_FLAGS,
-			    tb[TCA_RED_FLAGS], TC_RED_SUPPORTED_FLAGS,
-			    &flags_bf, &userbits, extack);
+			    tb[TCA_RED_FLAGS], &flags_bf, &userbits,
+			    extack);
 	if (err)
 		return err;
 
-- 
2.17.1