netdev - Re: [PATCH net-next] mlxsw: minimal: Return -ENOMEM on allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwoZ8V1Y++bUSLxj@shredder>
Date:   Sat, 27 Aug 2022 16:19:45 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Vadim Pasternak <vadimp@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...dia.com>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] mlxsw: minimal: Return -ENOMEM on allocation
 failure

On Fri, Aug 26, 2022 at 06:03:30PM +0300, Dan Carpenter wrote:
> These error paths return success but they should return -ENOMEM.
> 
> Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>

Thanks!