netdev - Re: [PATCH v2 net-next 3/5] tcp: Access &tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL0FpMHZ0YETN8DaO1Tj+P2kA1FBrH+8D4or9M9beqRug@mail.gmail.com>
Date:   Mon, 29 Aug 2022 16:03:50 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Kuniyuki Iwashima <kuni1840@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 3/5] tcp: Access &tcp_hashinfo via net.

On Mon, Aug 29, 2022 at 9:20 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> We will soon introduce an optional per-netns ehash.
>
> This means we cannot use tcp_hashinfo directly in most places.
>
> Instead, access it via net->ipv4.tcp_death_row->hashinfo.
>
> The access will be valid only while initialising tcp_hashinfo
> itself and creating/destroying each netns.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
>  .../mellanox/mlx5/core/en_accel/ktls_rx.c     |  5 +-
>  .../net/ethernet/netronome/nfp/crypto/tls.c   |  5 +-

I would probably omit changes in these two drivers, they look pure noise to me.

It is unfortunate enough that some drivers go deep in TCP stack, no need
to make your patches intrusive.