netdev - Re: [PATCH v2 net-next 3/5] tcp: Access &tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220829232230.20308-1-kuniyu@amazon.com>
Date:   Mon, 29 Aug 2022 16:22:30 -0700
From:   Kuniyuki Iwashima <kuniyu@...zon.com>
To:     <edumazet@...gle.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <kuni1840@...il.com>,
        <kuniyu@...zon.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v2 net-next 3/5] tcp: Access &tcp_hashinfo via net.

From:   Eric Dumazet <edumazet@...gle.com>
Date:   Mon, 29 Aug 2022 16:03:50 -0700
> On Mon, Aug 29, 2022 at 9:20 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
> >
> > We will soon introduce an optional per-netns ehash.
> >
> > This means we cannot use tcp_hashinfo directly in most places.
> >
> > Instead, access it via net->ipv4.tcp_death_row->hashinfo.
> >
> > The access will be valid only while initialising tcp_hashinfo
> > itself and creating/destroying each netns.
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> > ---
> >  .../mellanox/mlx5/core/en_accel/ktls_rx.c     |  5 +-
> >  .../net/ethernet/netronome/nfp/crypto/tls.c   |  5 +-
> 
> I would probably omit changes in these two drivers, they look pure noise to me.
> 
> It is unfortunate enough that some drivers go deep in TCP stack, no need
> to make your patches intrusive.

Ok, I'll drop them.