netdev - Re: [PATCH wpan-next 01/20] net: mac802154: Allow the creation of coordinator interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220829100521.04b52196@xps-13>
Date:   Mon, 29 Aug 2022 10:05:21 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Alexander Aring <aahringo@...hat.com>
Cc:     Alexander Aring <alex.aring@...il.com>,
        Stefan Schmidt <stefan@...enfreihafen.org>,
        linux-wpan - ML <linux-wpan@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Network Development <netdev@...r.kernel.org>,
        David Girault <david.girault@...vo.com>,
        Romuald Despres <romuald.despres@...vo.com>,
        Frederic Blain <frederic.blain@...vo.com>,
        Nicolas Schodet <nico@...fr.eu.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH wpan-next 01/20] net: mac802154: Allow the creation of
 coordinator interfaces

Hi Alexander,

aahringo@...hat.com wrote on Sun, 28 Aug 2022 22:31:19 -0400:

> Hi,
> 
> On Fri, Aug 26, 2022 at 4:08 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> ...
> > >
> > > I need to say that I really used multiple monitors at the same time on
> > > one phy only and I did that with hwsim to run multiple user space
> > > stacks. It was working and I was happy and didn't need to do a lot of
> > > phy creations in hwsim.  
> >
> > Indeed, looking at the code, you could use as many MONITOR interfaces
> > you needed, but only a single NODE. I've changed that to use as many
> > NODE and COORD that we wish.
> >  
> 
> Be careful there, there is a reason why we don't allow this and this
> has to do with support of multiple address filters... but here it
> depends also what you mean with "use".

I've updated this part, you're right I was not careful enough on the
per-iface filtering part, I think it's fine now. Basically, compared to
the v2 sent last week, I've stopped considering that if one interface
was in promiscuous mode, all of them should and did a per-PHY check, so
that otherwise we can apply the necessary filtering if needed.

> I need to admit, you can achieve the same behaviour of multiple user
> space stacks and one monitor, _but_ you can easily filter the traffic
> if you do it per interface...

Thanks,
Miquèl