netdev - Re: [PATCH net 2/2] net: Use u64_stats_fetch_begin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwyNDi3p72DBvZ/3@corigine.com>
Date:   Mon, 29 Aug 2022 11:55:26 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Catherine Sullivan <csully@...gle.com>,
        David Awogbemila <awogbemila@...gle.com>,
        Dimitris Michailidis <dmichail@...gible.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Jeroen de Borst <jeroendb@...gle.com>,
        Johannes Berg <johannes@...solutions.net>,
        Linus Walleij <linus.walleij@...aro.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-wireless@...r.kernel.org, oss-drivers@...igine.com,
        stable@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: Use u64_stats_fetch_begin_irq() for stats
 fetch.

On Thu, Aug 25, 2022 at 01:36:45PM +0200, Sebastian Andrzej Siewior wrote:
> On 32bit-UP u64_stats_fetch_begin() disables only preemption. If the
> reader is in preemptible context and the writer side
> (u64_stats_update_begin*()) runs in an interrupt context (IRQ or
> softirq) then the writer can update the stats during the read operation.
> This update remains undetected.
> 
> Use u64_stats_fetch_begin_irq() to ensure the stats fetch on 32bit-UP
> are not interrupted by a writer. 32bit-SMP remains unaffected by this
> change.

Thanks,

for the NFP driver portion:

Reviewed-by: Simon Horman <simon.horman@...igine.com>