netdev - Re: [PATCH v2 linux-next] wifi: brcmfmac: remove redundant err variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 13:35:04 +0200
From:   Arend Van Spriel <aspriel@...il.com>
To:     cgel.zte@...il.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, kvalo@...nel.org, davem@...emloft.net,
        edumazet@...gle.com
Cc:     kuba@...nel.org, pabeni@...hat.com, johannes.berg@...el.com,
        alsi@...g-olufsen.dk, a.fatoum@...gutronix.de,
        loic.poulain@...aro.org, quic_vjakkam@...cinc.com,
        prestwoj@...il.com, colin.i.king@...il.com, hdegoede@...hat.com,
        smoch@....de, cui.jinpeng2@....com.cn,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH v2 linux-next] wifi: brcmfmac: remove redundant err
 variable

On 8/30/2022 12:50 PM, cgel.zte@...il.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@....com.cn>
> 
> Return value from brcmf_fil_iovar_data_set() and
> brcmf_config_ap_mgmt_ie() directly instead of
> taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@....com.cn>
> ---
>   .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c    | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 7c72ea26a7d7..8a8c5a3bb2fb 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
[...]

> @@ -3997,10 +3996,8 @@ brcmf_update_pmklist(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp)
>   	for (i = 0; i < npmk; i++)
>   		brcmf_dbg(CONN, "PMK[%d]: %pM\n", i, &pmk_list->pmk[i].bssid);
>   
> -	err = brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
> +	return brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
>   				       sizeof(*pmk_list));

You should align the next line on the column after the opening brace. 
Using the checkpatch script should report this.

> -
> -	return err;
>   }
>   
>   static s32