netdev - Re: [PATCH net-next 0/5] net: wwan: t7xx: fw flashing & coredump support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 04:51:43 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     M Chetan Kumar <m.chetan.kumar@...el.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Johannes Berg <johannes@...solutions.net>,
        Loic Poulain <loic.poulain@...aro.org>,
        "Sudi, Krishna C" <krishna.c.sudi@...el.com>,
        M Chetan Kumar <m.chetan.kumar@...ux.intel.com>,
        Intel Corporation <linuxwwan@...el.com>
Subject: Re: [PATCH net-next 0/5] net: wwan: t7xx: fw flashing & coredump support

Hello,

On Tue, Aug 16, 2022 at 7:11 AM <m.chetan.kumar@...el.com> wrote:
> This patch series brings-in the support for FM350 wwan device firmware
> flashing & coredump collection using devlink interface.
>
> Below is the high level description of individual patches.
> Refer to individual patch commit message for details.
>
> PATCH1:  Enables AP CLDMA communication for firmware flashing &
> coredump collection.
>
> PATCH2: Enables the infrastructure & queue configuration required
> for early ports enumeration.
>
> PATCH3: Implements device reset and rescan logic required to enter
> or exit fastboot mode.
>
> PATCH4: Implements devlink interface & uses the fastboot protocol for
> fw flashing and coredump collection.
>
> PATCH5: t7xx devlink commands documentation.

Generally the code looks good to me, but needs some cleanup. It also
has a couple of questionable parts:
* implicit fastboot mode entering;
* PCI device reset handling approach.

Please find comments in the corresponding patches.

-- 
Sergey