lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Aug 2022 16:47:33 +0100 From: Edward Cree <ecree.xilinx@...il.com> To: Íñigo Huguet <ihuguet@...hat.com>, Jakub Kicinski <kuba@...nel.org> Cc: habetsm.xilinx@...il.com, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next v3 2/3] sfc: support PTP over IPv6/UDP On 26/08/2022 07:39, Íñigo Huguet wrote: > On Fri, Aug 26, 2022 at 3:32 AM Jakub Kicinski <kuba@...nel.org> wrote: >> >> On Thu, 25 Aug 2022 11:02:41 +0200 Íñigo Huguet wrote: >>> +static inline int >>> +efx_filter_set_ipv6_local(struct efx_filter_spec *spec, u8 proto, >>> + const struct in6_addr *host, __be16 port) >> >> also - unclear why this is defined in the header >> > > This is just because it's the equivalent of other already existing > similar functions in that file. I think I should keep this one > untouched for cohesion. My preference would be to keep this in filter.h as Íñigo currently has it, to follow the existing pattern. These "populate a filter spec" functions are really just typesafe macros. -ed
Powered by blists - more mailing lists