netdev - Re: [PATCH net] nfp: fix the access to management firmware hanging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <687cb51d-8a57-ef60-5432-e63f4c01b53c@intel.com>
Date:   Tue, 30 Aug 2022 11:42:01 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Simon Horman <simon.horman@...igine.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC:     <netdev@...r.kernel.org>, <oss-drivers@...igine.com>
Subject: Re: [PATCH net] nfp: fix the access to management firmware hanging

On 8/29/2022 3:16 AM, Simon Horman wrote:
> From: Gao Xiao <gao.xiao@...igine.com>
> 
> When running `ethtool -p` with the old management firmware,
> the management firmware resource is not correctly released,
> which causes firmware related malfunction: all the access
> to management firmware hangs.
> 
> It releases the management firmware resource when set id
> mode operation is not supported.
> 
> Fixes: ccb9bc1dfa44 ("nfp: add 'ethtool --identify' support")
> Signed-off-by: Gao Xiao <gao.xiao@...igine.com>
> Reviewed-by: Louis Peens <louis.peens@...igine.com>
> Signed-off-by: Simon Horman <simon.horman@...igine.com>

Looks sane!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>