netdev - Re: [PATCH net-next 0/3] net: sched: add other statistics when calling qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220829214846.3fbb41b1@kernel.org>
Date:   Mon, 29 Aug 2022 21:48:46 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     shaozhengchao <shaozhengchao@...wei.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
        <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next 0/3] net: sched: add other statistics when
 calling qdisc_drop()

On Sat, 27 Aug 2022 11:16:53 +0800 shaozhengchao wrote:
> On 2022/8/27 10:40, Jakub Kicinski wrote:
> > On Thu, 25 Aug 2022 11:29:40 +0800 Zhengchao Shao wrote:  
> >> According to the description, "other" should be added when calling
> >> qdisc_drop() to discard packets.  
> > 
> > The fact that an old copy & pasted comment says something is not
> > in itself a sufficient justification to make code changes.
> > 
> > qdisc_drop() already counts drops, duplicating the same information
> > in another place seems like a waste of CPU cycles.  
> 
> Hi Jakub:
> 	Thank you for your reply. It seems more appropriate to delete the other 
> variable, if it is unused?

Yes, removing it SGTM.