netdev - Re: [PATCH ipsec] esp: choose the correct inner protocol for GSO on inter address family tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220830062714.GN2950045@gauss3.secunet.de>
Date:   Tue, 30 Aug 2022 08:27:14 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec] esp: choose the correct inner protocol for GSO on
 inter address family tunnels

On Thu, Aug 25, 2022 at 05:16:51PM +0200, Sabrina Dubroca wrote:
> Commit 23c7f8d7989e ("net: Fix esp GSO on inter address family
> tunnels.") is incomplete. It passes to skb_eth_gso_segment the
> protocol for the outer IP version, instead of the inner IP version, so
> we end up calling inet_gso_segment on an inner IPv6 packet and
> ipv6_gso_segment on an inner IPv4 packet and the packets are dropped.
> 
> This patch completes the fix by selecting the correct protocol based
> on the inner mode's family.
> 
> Fixes: c35fe4106b92 ("xfrm: Add mode handlers for IPsec on layer 2")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied, thanks a lot Sabrina!