netdev - Re: [Patch net-next v2 0/9] net: dsa: microchip: add support for phylink mac config and link up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 08:15:59 +0000
From:   <Arun.Ramadoss@...rochip.com>
To:     <o.rempel@...gutronix.de>
CC:     <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>, <vivien.didelot@...il.com>,
        <san@...v.dk>, <olteanv@...il.com>, <linux@...linux.org.uk>,
        <f.fainelli@...il.com>, <kuba@...nel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <Woojung.Huh@...rochip.com>, <davem@...emloft.net>
Subject: Re: [Patch net-next v2 0/9] net: dsa: microchip: add support for
 phylink mac config and link up

Hi Oleksij,
Is this Bug related to fix in 
https://lore.kernel.org/lkml/20220829105810.577903823@linuxfoundation.org/
. 
It is observed in ksz8794 switch. I think after applying this bug fix
patch it should work. I don't have ksz8 series to test. I ran the
regression only for ksz9 series switches. 


On Tue, 2022-08-30 at 08:55 +0200, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Hi Arun,
> 
> starting with this patch set I have following regression on ksz8873
> switch. Can you please take a look at it:
>  8<--- cut here ---
>  Unable to handle kernel NULL pointer dereference at virtual address
> 00000005
>  ksz8863-switch gpio-0:00: nonfatal error -34 setting MTU to 1500 on
> port 0
> ...
>  Modules linked in:
>  CPU: 0 PID: 16 Comm: kworker/0:1 Not tainted 6.0.0-rc2-00436-
> g3da285df1324 #74
>  Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
>  Workqueue: events_power_efficient phylink_resolve
>  PC is at ksz_set_gbit+0x5c/0xa4
>  LR is at arch_atomic_cmpxchg_relaxed+0x1c/0x38
> ....
>  Backtrace:
>   ksz_set_gbit from ksz_phylink_mac_link_up+0x15c/0x1c8
>   ksz_phylink_mac_link_up from dsa_port_phylink_mac_link_up+0x7c/0x80
>   dsa_port_phylink_mac_link_up from phylink_resolve+0x304/0x3d0
>   phylink_resolve from process_one_work+0x214/0x31c
>   process_one_work from worker_thread+0x254/0x2d4
>   worker_thread from kthread+0xfc/0x108
>   kthread from ret_from_fork+0x14/0x2c
> ...
>  ksz8863-switch gpio-0:00 lan2 (uninitialized): PHY [dsa-0.0:01]
> driver [Micrel KSZ8851 Ethernet MAC or KSZ886X Switch] (irq=POLL)
>  ksz8863-switch gpio-0:00: nonfatal error -34 setting MTU to 1500 on
> port 1
>  device eth0 entered promiscuous mode
>  DSA: tree 0 setup
>  ---[ end trace 0000000000000000 ]---
> 
> Regards,
> Oleksij
> 
> On Sun, Jul 24, 2022 at 02:58:14PM +0530, Arun Ramadoss wrote:
> > This patch series add support common phylink mac config and link up
> > for the ksz
> > series switches. At present, ksz8795 and ksz9477 doesn't implement
> > the phylink
> > mac config and link up. It configures the mac interface in the port
> > setup hook.
> > ksz8830 series switch does not mac link configuration. For lan937x
> > switches, in
> > the part support patch series has support only for MII and RMII
> > configuration.
> > Some group of switches have some register address and bit fields
> > common and
> > others are different. So, this patch aims to have common phylink
> > implementation
> > which configures the register based on the chip id.
> > Changes in v2
> > - combined the modification of duplex, tx_pause and rx_pause into
> > single
> >   function.
> > 
> > Changes in v1
> > - Squash the reading rgmii value from dt to patch which apply the
> > rgmii value
> > - Created the new function ksz_port_set_xmii_speed
> > - Seperated the namespace values for xmii_ctrl_0 and xmii_ctrl_1
> > register
> > - Applied the rgmii delay value based on the rx/tx-internal-delay-
> > ps
> > 
> > Arun Ramadoss (9):
> >   net: dsa: microchip: add common gigabit set and get function
> >   net: dsa: microchip: add common ksz port xmii speed selection
> > function
> >   net: dsa: microchip: add common duplex and flow control function
> >   net: dsa: microchip: add support for common phylink mac link up
> >   net: dsa: microchip: lan937x: add support for configuing xMII
> > register
> >   net: dsa: microchip: apply rgmii tx and rx delay in phylink mac
> > config
> >   net: dsa: microchip: ksz9477: use common xmii function
> >   net: dsa: microchip: ksz8795: use common xmii function
> >   net: dsa: microchip: add support for phylink mac config
> > 
> >  drivers/net/dsa/microchip/ksz8795.c      |  40 ---
> >  drivers/net/dsa/microchip/ksz8795_reg.h  |   8 -
> >  drivers/net/dsa/microchip/ksz9477.c      | 183 +------------
> >  drivers/net/dsa/microchip/ksz9477_reg.h  |  24 --
> >  drivers/net/dsa/microchip/ksz_common.c   | 312
> > ++++++++++++++++++++++-
> >  drivers/net/dsa/microchip/ksz_common.h   |  54 ++++
> >  drivers/net/dsa/microchip/lan937x.h      |   8 +-
> >  drivers/net/dsa/microchip/lan937x_main.c | 125 +++------
> >  drivers/net/dsa/microchip/lan937x_reg.h  |  32 ++-
> >  9 files changed, 431 insertions(+), 355 deletions(-)
> > 
> > 
> > base-commit: 502c6f8cedcce7889ccdefeb88ce36b39acd522f
> > --
> > 2.36.1
> > 
> 
> --
> Pengutronix
> e.K.                           |                             |
> Steuerwalder Str. 21                       | 
> http://www.pengutronix.de/e/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-
> 0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-
> 5555 |