netdev - Re: [PATCH v2 1/3] ipv4: Namespaceify route/error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 09:47:01 +0000
From:   CGEL <cgel.zte@...il.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, kuba@...nel.org, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linl@...r.kernel.org, xu.xin16@....com.cn,
        Yunkai Zhang <zhang.yunkai@....com.cn>
Subject: Re: [PATCH v2 1/3] ipv4: Namespaceify route/error_cost knob

On Thu, Aug 25, 2022 at 08:23:56AM -0700, David Ahern wrote:
> On 8/23/22 7:03 PM, cgel.zte@...il.com wrote:
> > diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> > index 795cbe1de912..b022ae749640 100644
> > --- a/net/ipv4/route.c
> > +++ b/net/ipv4/route.c
> > @@ -118,7 +118,6 @@ static int ip_rt_max_size;
> >  static int ip_rt_redirect_number __read_mostly	= 9;
> >  static int ip_rt_redirect_load __read_mostly	= HZ / 50;
> >  static int ip_rt_redirect_silence __read_mostly	= ((HZ / 50) << (9 + 1));
> > -static int ip_rt_error_cost __read_mostly	= HZ;
> >  static int ip_rt_error_burst __read_mostly	= 5 * HZ;
> >  
> >  static int ip_rt_gc_timeout __read_mostly	= RT_GC_TIMEOUT;
> > @@ -949,6 +948,7 @@ static int ip_error(struct sk_buff *skb)
> >  	SKB_DR(reason);
> >  	bool send;
> >  	int code;
> > +	int error_cost;
> 
> can be moved to below where it is needed
> >  
> >  	if (netif_is_l3_master(skb->dev)) {
> >  		dev = __dev_get_by_index(dev_net(skb->dev), IPCB(skb)->iif);
> > @@ -1002,11 +1002,13 @@ static int ip_error(struct sk_buff *skb)
> >  	if (peer) {
> 
> to here and then name it ip_rt_error_cost and you don't need to
> 		int ip_rt_error_cost = READ_ONCE(net->ipv4.ip_rt_error_cost);
> 
> make changes to the algorithm.

Yes, done.

> 
> Also, why not ip_rt_error_burst as well? part of the same algorithm.

done.