netdev - Re: [PATCH v2] net: fec: Use unlocked timecounter reads for saving state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 18:20:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Csókás Bence <csokas.bence@...lan.hu>,
        netdev@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Richard Cochran <richardcochran@...il.com>,
        Jakub Kicinski <kuba@...nel.org>, qiangqing.zhang@....com,
        Andrew Lunn <andrew@...n.ch>, kernel@...gutronix.de,
        Csókás Bence <csokas.bence@...lan.hu>,
        Marc Kleine-Budde <mkl@...gutronix.de>
Subject: Re: [PATCH v2] net: fec: Use unlocked timecounter reads for saving
 state

Hi "Csókás,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on net-next/master linus/master v6.0-rc3 next-20220831]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cs-k-s-Bence/net-fec-Use-unlocked-timecounter-reads-for-saving-state/20220830-191644
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git b05972f01e7d30419987a1f221b5593668fd6448
config: arm-mxs_defconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1c66bacd6cde1f37d6ac96c45b389666a1334ec0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/1b907e75a5f827529bfe24d68038c69fac840901
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cs-k-s-Bence/net-fec-Use-unlocked-timecounter-reads-for-saving-state/20220830-191644
        git checkout 1b907e75a5f827529bfe24d68038c69fac840901
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/freescale/fec_ptp.c:648:6: error: call to undeclared function 'preempt_count_equals'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (preempt_count_equals(0)) {
               ^
>> drivers/net/ethernet/freescale/fec_ptp.c:649:39: error: use of undeclared identifier 'flags'
                   spin_lock_irqsave(&fep->tmreg_lock, flags);
                                                       ^
>> drivers/net/ethernet/freescale/fec_ptp.c:649:39: error: use of undeclared identifier 'flags'
   drivers/net/ethernet/freescale/fec_ptp.c:651:44: error: use of undeclared identifier 'flags'
                   spin_unlock_irqrestore(&fep->tmreg_lock, flags);
                                                            ^
   4 errors generated.


vim +/preempt_count_equals +648 drivers/net/ethernet/freescale/fec_ptp.c

   643	
   644	void fec_ptp_save_state(struct fec_enet_private *fep)
   645	{
   646		u32 atime_inc_corr;
   647	
 > 648		if (preempt_count_equals(0)) {
 > 649			spin_lock_irqsave(&fep->tmreg_lock, flags);
   650			fep->ptp_saved_state.ns_phc = timecounter_read(&fep->tc);
   651			spin_unlock_irqrestore(&fep->tmreg_lock, flags);
   652		} else {
   653			fep->ptp_saved_state.ns_phc = timecounter_read(&fep->tc);
   654		}
   655		fep->ptp_saved_state.ns_sys = ktime_get_ns();
   656	
   657		fep->ptp_saved_state.at_corr = readl(fep->hwp + FEC_ATIME_CORR);
   658		atime_inc_corr = readl(fep->hwp + FEC_ATIME_INC) & FEC_T_INC_CORR_MASK;
   659		fep->ptp_saved_state.at_inc_corr = (u8)(atime_inc_corr >> FEC_T_INC_CORR_OFFSET);
   660	}
   661	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (120663 bytes)