netdev - Re: [PATCH net 2/2] tcp: make global challenge ack rate limitation per net-ns and default disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQyn+SU9FM1uRM1U-t1eUGd_q2M6FS3n+71Kbmhy9OD=f2w@mail.gmail.com>
Date:   Wed, 31 Aug 2022 08:59:50 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>, Jason Baron <jbaron@...mai.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net 2/2] tcp: make global challenge ack rate limitation
 per net-ns and default disabled

On Tue, Aug 30, 2022 at 2:57 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> Because per host rate limiting has been proven problematic (side channel
> attacks can be based on it), per host rate limiting of challenge acks ideally
> should be per netns and turned off by default.
>
> This is a long due followup of following commits:
>
> 083ae308280d ("tcp: enable per-socket rate limiting of all 'challenge acks'")
> f2b2c582e824 ("tcp: mitigate ACK loops for connections as tcp_sock")
> 75ff39ccc1bd ("tcp: make challenge acks less predictable")
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Jason Baron <jbaron@...mai.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> ---

Acked-by: Neal Cardwell <ncardwell@...gle.com>

Looks great. Thanks, Eric!

neal