netdev - Re: [virtio-dev] Re: [PATCH RESEND v4 1/2] virtio-net: introduce and use helper function for guest gso support checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f60e5ab-dfba-0e02-5d7f-ebd6bebf2572@nvidia.com>
Date:   Wed, 31 Aug 2022 21:10:23 +0800
From:   Gavin Li <gavinl@...dia.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     stephen@...workplumber.org, davem@...emloft.net,
        jesse.brandeburg@...el.com, alexander.h.duyck@...el.com,
        kuba@...nel.org, sridhar.samudrala@...el.com, jasowang@...hat.com,
        loseweigh@...il.com, netdev@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        virtio-dev@...ts.oasis-open.org, gavi@...dia.com, parav@...dia.com,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Si-Wei Liu <si-wei.liu@...cle.com>
Subject: Re: [virtio-dev] Re: [PATCH RESEND v4 1/2] virtio-net: introduce and
 use helper function for guest gso support checks


On 8/31/2022 9:08 PM, Michael S. Tsirkin wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Aug 31, 2022 at 04:05:40PM +0300, Gavin Li wrote:
>> Probe routine is already several hundred lines.
>> Use helper function for guest gso support check.
>>
>> Signed-off-by: Gavin Li <gavinl@...dia.com>
>> Reviewed-by: Gavi Teitz <gavi@...dia.com>
>> Reviewed-by: Parav Pandit <parav@...dia.com>
>> Reviewed-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
>> Reviewed-by: Si-Wei Liu <si-wei.liu@...cle.com>
>> ---
>> changelog:
>> v1->v2
>> - Add new patch
>> ---
>>   drivers/net/virtio_net.c | 13 +++++++++----
>>   1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index 9cce7dec7366..e1904877d461 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
>> @@ -3682,6 +3682,14 @@ static int virtnet_validate(struct virtio_device *vdev)
>>        return 0;
>>   }
>>
>> +static bool virtnet_check_guest_gso(const struct virtnet_info *vi)
>> +{
>> +     return (virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) ||
>> +             virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) ||
>> +             virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) ||
>> +             virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO));
>> +}
>> +
> fine but can we please drop the outer ()?
> they are necessary with if but not with return.
ACK
>
>
>>   static int virtnet_probe(struct virtio_device *vdev)
>>   {
>>        int i, err = -ENOMEM;
>> @@ -3777,10 +3785,7 @@ static int virtnet_probe(struct virtio_device *vdev)
>>        spin_lock_init(&vi->refill_lock);
>>
>>        /* If we can receive ANY GSO packets, we must allocate large ones. */
>> -     if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) ||
>> -         virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) ||
>> -         virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN) ||
>> -         virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_UFO))
>> +     if (virtnet_check_guest_gso(vi))
>>                vi->big_packets = true;
>>
>>        if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
>> --
>> 2.31.1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@...ts.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@...ts.oasis-open.org
>