lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAK-6q+jy5f7PSAh1pZe3M6LM-ySLfUpBAjqS48mBKEVKgXPCUw@mail.gmail.com> Date: Wed, 31 Aug 2022 15:21:10 -0400 From: Alexander Aring <aahringo@...hat.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Gal Pressman <gal@...dia.com>, "David S. Miller" <davem@...emloft.net>, Network Development <netdev@...r.kernel.org>, Leon Romanovsky <leonro@...dia.com>, Stefan Schmidt <stefan@...enfreihafen.org>, linux-wpan - ML <linux-wpan@...r.kernel.org>, Alexander Aring <alex.aring@...il.com> Subject: Re: [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled Hi, On Wed, Aug 31, 2022 at 2:26 PM Jakub Kicinski <kuba@...nel.org> wrote: > > On Tue, 30 Aug 2022 23:31:24 -0700 Jakub Kicinski wrote: > > Hm, let me add 802154 folks. > > > > Either we should treat the commands as reserved in terms of uAPI > > even if they get removed the IDs won't be reused, or they are for > > testing purposes only. > > > > In the former case we should just remove the #ifdef around the values > > in the enum, it just leads to #ifdef proliferation while having no > > functional impact. > > > > In the latter case we should start error checking from the last > > non-experimental command, as we don't care about breaking the > > experimental ones. > > I haven't gone thru all of my inbox yet, but I see no reply from Stefan > or Alexander. My vote is to un-hide the EXPERIMENTAL commands. > fine for me if it's still in nl802154 and ends in error if somebody tries to use it and it's not compiled. But users should still consider it's not a stable API yet and we don't care about breaking it for now... - Alex
Powered by blists - more mailing lists