netdev - Re: [PATCH v2 intel-net 1/2] ice: xsk: change batched Tx descriptor cleaning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e559af7-bc84-95fb-7cea-224b7a3da0e2@intel.com>
Date:   Wed, 31 Aug 2022 13:14:08 -0700
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        <intel-wired-lan@...ts.osuosl.org>
CC:     <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <magnus.karlsson@...el.com>, <alasdair.mcwilliam@...look.com>
Subject: Re: [PATCH v2 intel-net 1/2] ice: xsk: change batched Tx descriptor
 cleaning

On 8/30/2022 5:51 AM, Maciej Fijalkowski wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.h b/drivers/net/ethernet/intel/ice/ice_xsk.h
> index 21faec8e97db..35dd3c57c4df 100644
> --- a/drivers/net/ethernet/intel/ice/ice_xsk.h
> +++ b/drivers/net/ethernet/intel/ice/ice_xsk.h
> @@ -26,12 +26,9 @@ bool ice_alloc_rx_bufs_zc(struct ice_rx_ring *rx_ring, u16 count);
>   bool ice_xsk_any_rx_ring_ena(struct ice_vsi *vsi);
>   void ice_xsk_clean_rx_ring(struct ice_rx_ring *rx_ring);
>   void ice_xsk_clean_xdp_ring(struct ice_tx_ring *xdp_ring);
> -bool ice_xmit_zc(struct ice_tx_ring *xdp_ring, u32 budget, int napi_budget);
> +bool ice_xmit_zc(struct ice_tx_ring *xdp_ring);
>   #else
> -static inline bool

Looks like this shouldn't be deleted.

> -ice_xmit_zc(struct ice_tx_ring __always_unused *xdp_ring,
> -	    u32 __always_unused budget,
> -	    int __always_unused napi_budget)
> +ice_xmit_zc(struct ice_tx_ring __always_unused *xdp_ring)
>   {
>   	return false;
>   }