netdev - RE: [PATCH net-next v1] r8152: allow userland to disable multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b94fb55a06cc4ea5aeb32e919e9607a1@realtek.com>
Date:   Wed, 31 Aug 2022 03:14:42 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Sven van Ashbrook <svenva@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>
CC:     Alex Levin <levinale@...gle.com>,
        Chithra Annegowda <chithraa@...gle.com>,
        Frank Gorgenyi <frankgor@...gle.com>,
        Aaron Ma <aaron.ma@...onical.com>,
        David Ober <dober6023@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Hao Chen <chenhao288@...ilicon.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jean-Francois Le Fillatre <jflf_kernel@....com>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v1] r8152: allow userland to disable multicast

Sven van Ashbrook <svenva@...omium.org>
> Sent: Tuesday, August 30, 2022 1:00 PM
[...]
> The rtl8152 driver does not disable multicasting when userspace asks
> it to. For example:
>  $ ifconfig eth0 -multicast -allmulti
>  $ tcpdump -p -i eth0  # will still capture multicast frames
> 
> Fix by clearing the device multicast filter table when multicast and
> allmulti are both unset.
> 
> Tested as follows:
> - Set multicast on eth0 network interface
> - verify that multicast packets are coming in:
>   $ tcpdump -p -i eth0
> - Clear multicast and allmulti on eth0 network interface
> - verify that no more multicast packets are coming in:
>   $ tcpdump -p -i eth0
> 
> Signed-off-by: Sven van Ashbrook <svenva@...omium.org>

Acked-by: Hayes Wang <hayeswang@...ltek.com>

Best Regards,
Hayes