netdev - Re: [PATCH net v2] iavf: Detach device during reset task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 09:05:40 +0200
From:   Ivan Vecera <ivecera@...hat.com>
To:     "Laba, SlawomirX" <slawomirx.laba@...el.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Keller, Jacob E" <jacob.e.keller@...el.com>,
        "Piotrowski, Patryk" <patryk.piotrowski@...el.com>,
        Vitaly Grinberg <vgrinber@...hat.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@...ts.osuosl.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] iavf: Detach device during reset task

On Tue, 30 Aug 2022 20:49:54 +0000
"Laba, SlawomirX" <slawomirx.laba@...el.com> wrote:

> Ivan, what do you think about this flow [1]? Shouldn't it also goto reset_finish label?
> 
> 	if (i == IAVF_RESET_WAIT_COMPLETE_COUNT) {
> 		dev_err(&adapter->pdev->dev, "Reset never finished (%x)\n",
> 			reg_val);
> 		iavf_disable_vf(adapter);
> 		mutex_unlock(&adapter->client_lock);
> 		mutex_unlock(&adapter->crit_lock);
> 		return; /* Do not attempt to reinit. It's dead, Jim. */
> 	}
> 
> I am concerned that if the reset never finishes and iavf goes into disabled state, and then for example if driver reload operation is performed, bad things can happen.

I think we should not re-attach device back as the VF is disabled. Detached device causes that userspace (user) won't be able to configure associated interface
that is correct. Driver reload won't cause anything special in this situation because during module removal the interface is unregistered.

Thanks,
Ivan