netdev - Re: [PATCH v5 bpf-next 3/6] selftests: xsk: increase chars for interface name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ8uoz1sbkE+_-5B3BZQZ-8MqbXVkSi-YkoGEfvBsJa0n_oq9g@mail.gmail.com>
Date:   Wed, 31 Aug 2022 10:55:05 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, netdev@...r.kernel.org,
        magnus.karlsson@...el.com, bjorn@...nel.org
Subject: Re: [PATCH v5 bpf-next 3/6] selftests: xsk: increase chars for
 interface name

On Tue, Aug 30, 2022 at 4:00 PM Maciej Fijalkowski
<maciej.fijalkowski@...el.com> wrote:
>
> So that "enp240s0f0" or such name can be used against xskxceiver.

Why not bump them up to 16 why you are at it, including
MAX_INTERFACES_NAMESPACE_CHARS? In any case:

Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>

> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  tools/testing/selftests/bpf/xskxceiver.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/xskxceiver.h b/tools/testing/selftests/bpf/xskxceiver.h
> index 8d1c31f127e7..12bfa6e463d3 100644
> --- a/tools/testing/selftests/bpf/xskxceiver.h
> +++ b/tools/testing/selftests/bpf/xskxceiver.h
> @@ -29,7 +29,7 @@
>  #define TEST_FAILURE -1
>  #define TEST_CONTINUE 1
>  #define MAX_INTERFACES 2
> -#define MAX_INTERFACE_NAME_CHARS 7
> +#define MAX_INTERFACE_NAME_CHARS 10
>  #define MAX_INTERFACES_NAMESPACE_CHARS 10
>  #define MAX_SOCKETS 2
>  #define MAX_TEST_NAME_SIZE 32
> --
> 2.34.1
>