lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Sep 2022 05:10:37 +0300 From: Gavin Li <gavinl@...dia.com> To: <stephen@...workplumber.org>, <davem@...emloft.net>, <jesse.brandeburg@...el.com>, <alexander.h.duyck@...el.com>, <kuba@...nel.org>, <sridhar.samudrala@...el.com>, <jasowang@...hat.com>, <loseweigh@...il.com>, <netdev@...r.kernel.org>, <virtualization@...ts.linux-foundation.org>, <virtio-dev@...ts.oasis-open.org>, <mst@...hat.com> CC: <gavi@...dia.com>, <parav@...dia.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Si-Wei Liu <si-wei.liu@...cle.com> Subject: [PATCH v5 1/2] virtio-net: introduce and use helper function for guest gso support checks Probe routine is already several hundred lines. Use helper function for guest gso support check. Signed-off-by: Gavin Li <gavinl@...dia.com> Reviewed-by: Gavi Teitz <gavi@...dia.com> Reviewed-by: Parav Pandit <parav@...dia.com> Reviewed-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com> Reviewed-by: Si-Wei Liu <si-wei.liu@...cle.com> --- changelog: v4->v5 - Addressed comments from Michael S. Tsirkin - Remove unnecessary () in return clause v1->v2 - Add new patch --- drivers/net/virtio_net.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 9cce7dec7366..f831a0290998 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -3682,6 +3682,14 @@ static int virtnet_validate(struct virtio_device *vdev) return 0; } +static bool virtnet_check_guest_gso(const struct virtnet_info *vi) +{ + return virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) || + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) || + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) || + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO); +} + static int virtnet_probe(struct virtio_device *vdev) { int i, err = -ENOMEM; @@ -3777,10 +3785,7 @@ static int virtnet_probe(struct virtio_device *vdev) spin_lock_init(&vi->refill_lock); /* If we can receive ANY GSO packets, we must allocate large ones. */ - if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) || - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) || - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN) || - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_UFO)) + if (virtnet_check_guest_gso(vi)) vi->big_packets = true; if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF)) -- 2.31.1
Powered by blists - more mailing lists