netdev - Re: [PATCH bpf-next v5 1/3] bpf: Add skb dynptrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJnrk1ZiYWu1R+mK5_OCZRBGLPx+_bE-fon30zDwSmrcxAxZQQ@mail.gmail.com>
Date:   Thu, 1 Sep 2022 14:58:59 -0700
From:   Joanne Koong <joannelkoong@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf@...r.kernel.org, andrii@...nel.org, daniel@...earbox.net,
        ast@...nel.org, memxor@...il.com, toke@...hat.com, kuba@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v5 1/3] bpf: Add skb dynptrs

On Thu, Sep 1, 2022 at 12:59 PM Martin KaFai Lau <kafai@...com> wrote:
>
> On Wed, Aug 31, 2022 at 11:32:22AM -0700, Joanne Koong wrote:
> > +#ifdef CONFIG_NET
> > +int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len);
> > +int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
> > +                       u32 len, u64 flags);
> > +#else /* CONFIG_NET */
> > +int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len)
> static inline
>
> This should address the build issue reported by the test bot.

Awesome, I will add this in for v6. Thanks!
>
> > +{
> > +     return -EOPNOTSUPP;
> > +}
> > +
> > +int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
> > +                       u32 len, u64 flags)
> Same here.
>
> > +{
> > +     return -EOPNOTSUPP;
> > +}
> > +#endif /* CONFIG_NET */