netdev - Re: [PATCH v3: net-next 3/4] net: dsa: microchip: ksz9477: remove 0x033C and 0x033D addresses from regmap_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220902112910.GB15827@pengutronix.de>
Date:   Fri, 2 Sep 2022 13:29:10 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Romain Naour <romain.naour@...le.fr>
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, kuba@...nel.org,
        edumazet@...gle.com, davem@...emloft.net, olteanv@...il.com,
        f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        UNGLinuxDriver@...rochip.com, woojung.huh@...rochip.com,
        Romain Naour <romain.naour@....com>
Subject: Re: [PATCH v3: net-next 3/4] net: dsa: microchip: ksz9477: remove
 0x033C and 0x033D addresses from regmap_access_tables

On Fri, Sep 02, 2022 at 12:16:09PM +0200, Romain Naour wrote:
> From: Romain Naour <romain.naour@....com>
> 
> According to the KSZ9477S datasheet, there is no global register
> at 0x033C and 0x033D addresses.
> 
> Signed-off-by: Romain Naour <romain.naour@....com>
> Cc: Oleksij Rempel <o.rempel@...gutronix.de>

Tested-by: Oleksij Rempel <o.rempel@...gutronix.de>

> ---
>  drivers/net/dsa/microchip/ksz_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
> index 02fb721c1090..a700631130e0 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -546,7 +546,8 @@ static const struct regmap_range ksz9477_valid_regs[] = {
>  	regmap_reg_range(0x0302, 0x031b),
>  	regmap_reg_range(0x0320, 0x032b),
>  	regmap_reg_range(0x0330, 0x0336),
> -	regmap_reg_range(0x0338, 0x033e),
> +	regmap_reg_range(0x0338, 0x033b),
> +	regmap_reg_range(0x033e, 0x033e),
>  	regmap_reg_range(0x0340, 0x035f),
>  	regmap_reg_range(0x0370, 0x0370),
>  	regmap_reg_range(0x0378, 0x0378),
> -- 
> 2.34.3
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |