netdev - Re: [PATCH] net: broadcom: Fix return type for implementation of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <794a683b-5885-659a-5b60-23d7ca6cc5a4@gmail.com>
Date:   Fri, 2 Sep 2022 08:35:03 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     GUO Zihua <guozihua@...wei.com>, netdev@...r.kernel.org
Cc:     rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH] net: broadcom: Fix return type for implementation of



On 9/2/2022 12:54 AM, GUO Zihua wrote:
> Since Linux now supports CFI, it will be a good idea to fix mismatched
> return type for implementation of hooks. Otherwise this might get
> cought out by CFI and cause a panic.
> 
> bcm4908_enet_start_xmit() would return either NETDEV_TX_BUSY or
> NETDEV_TX_OK, so change the return type to netdev_tx_t directly.
> 
> Signed-off-by: GUO Zihua <guozihua@...wei.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian