netdev - [PATCH net-next 4/6] net: ipa: simplify gsi_channel_trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220902210218.745873-5-elder@linaro.org>
Date:   Fri,  2 Sep 2022 16:02:16 -0500
From:   Alex Elder <elder@...aro.org>
To:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc:     mka@...omium.org, evgreen@...omium.org, bjorn.andersson@...aro.org,
        quic_cpratapa@...cinc.com, quic_avuyyuru@...cinc.com,
        quic_jponduru@...cinc.com, quic_subashab@...cinc.com,
        elder@...nel.org, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH net-next 4/6] net: ipa: simplify gsi_channel_trans_last()

Using a little logic we can simplify gsi_channel_trans_last().

The first condition in that function looks like this:
    if (trans_info->allocated_id != trans_info->free_id)
And if that's false, we proceed to the next one:
    if (trans_info->committed_id != trans_info->allocated_id)

Failure of the first test implies:
    trans_info->allocated_id == trans_info->free_id
And therefore, the second one can be rewritten this way:
    if (trans_info->committed_id != trans_info->free_id)

Substituting free_id for allocated_id and committed_id can also be
done in the code blocks executed when these conditions yield true.
The net result is that all three blocks for TX endpoints can be
consolidated into just one.

The two blocks of code at the end of that function (used for both TX
and RX channels) can be similarly consolidated into a single block.

Signed-off-by: Alex Elder <elder@...aro.org>
---
 drivers/net/ipa/gsi.c | 33 +++++++--------------------------
 1 file changed, 7 insertions(+), 26 deletions(-)

diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 0983a11409f2d..841a946bc286a 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -718,46 +718,27 @@ static struct gsi_trans *gsi_channel_trans_last(struct gsi_channel *channel)
 	 * before we disabled transmits, so check for that.
 	 */
 	if (channel->toward_ipa) {
-		/* The last allocated transaction precedes the first free */
-		if (trans_info->allocated_id != trans_info->free_id) {
+		/* The last allocated, committed, or pending transaction
+		 * precedes the first free transaction.
+		 */
+		if (trans_info->pending_id != trans_info->free_id) {
 			trans_id = trans_info->free_id - 1;
 			trans_index = trans_id % channel->tre_count;
 			trans = &trans_info->trans[trans_index];
 			goto done;
 		}
-
-		/* Last committed transaction precedes the first allocated */
-		if (trans_info->committed_id != trans_info->allocated_id) {
-			trans_id = trans_info->allocated_id - 1;
-			trans_index = trans_id % channel->tre_count;
-			trans = &trans_info->trans[trans_index];
-			goto done;
-		}
-
-		/* Last pending transaction precedes the first committed */
-		if (trans_info->pending_id != trans_info->committed_id) {
-			trans_id = trans_info->committed_id - 1;
-			trans_index = trans_id % channel->tre_count;
-			trans = &trans_info->trans[trans_index];
-			goto done;
-		}
 	}
 
 	/* Otherwise (TX or RX) we want to wait for anything that
 	 * has completed, or has been polled but not released yet.
 	 *
-	 * The last pending transaction precedes the first committed.
+	 * The last completed or polled transaction precedes the
+	 * first pending transaction.
 	 */
-	if (trans_info->completed_id != trans_info->pending_id) {
+	if (trans_info->polled_id != trans_info->pending_id) {
 		trans_id = trans_info->pending_id - 1;
 		trans_index = trans_id % channel->tre_count;
 		trans = &trans_info->trans[trans_index];
-		goto done;
-	}
-	if (trans_info->polled_id != trans_info->completed_id) {
-		trans_id = trans_info->completed_id - 1;
-		trans_index = trans_id % channel->tre_count;
-		trans = &trans_info->trans[trans_index];
 	} else {
 		trans = NULL;
 	}
-- 
2.34.1