lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <cf2f3ba9-c4fa-1618-f795-9a27b065ef56@prolan.hu> Date: Fri, 2 Sep 2022 09:18:48 +0200 From: Csókás Bence <csokas.bence@...lan.hu> To: Francesco Dolcini <francesco.dolcini@...adex.com> CC: <netdev@...r.kernel.org>, Richard Cochran <richardcochran@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>, <kernel@...gutronix.de>, Marc Kleine-Budde <mkl@...gutronix.de> Subject: Re: [PATCH v2] net: fec: Use a spinlock to guard `fep->ptp_clk_on` On 2022. 09. 01. 17:04, Francesco Dolcini wrote: > On Thu, Sep 01, 2022 at 04:04:03PM +0200, Csókás Bence wrote: >> Mutexes cannot be taken in a non-preemptible context, >> causing a panic in `fec_ptp_save_state()`. Replacing >> `ptp_clk_mutex` by `tmreg_lock` fixes this. >> >> Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled") > This should be removed, there was no issue with just this commit. Am I > wrong? > > One of the reasons of the Fixes tag is to backport to stable releases, > and you do not want this commit in 5.15.x. I do want it, actually, because I got a PATCH AUTOSEL already for f79959220fa5fbda939592bf91c7a9ea90419040 for 5.15 & 5.19, but I told them not to backport until this fix is merged too. Bence
Powered by blists - more mailing lists