netdev - RE: [PATCH net] net: fec: add pm_qos support on imx6q platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR04MB8106C5795E096F2CC87389B1887A9@DB9PR04MB8106.eurprd04.prod.outlook.com>
Date:   Fri, 2 Sep 2022 02:05:59 +0000
From:   Wei Fang <wei.fang@....com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net] net: fec: add pm_qos support on imx6q platform



> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: 2022年9月1日 15:18
> To: Wei Fang <wei.fang@....com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net] net: fec: add pm_qos support on imx6q platform
> 
> On Tue, 2022-08-30 at 15:01 +0800, wei.fang@....com wrote:
> > From: Wei Fang <wei.fang@....com>
> >
> > There is a very low probability that tx timeout will occur during
> > suspend and resume stress test on imx6q platform. So we add pm_qos
> > support to prevent system from entering low level idles which may
> > affect the transmission of tx.
> >
> > Signed-off-by: Wei Fang <wei.fang@....com>
> 
> Since this IMHO causes a significal behavior change I suggest to target the
> net-next tree, does that fit you?
> 
In my opinion, the patch is to fix a bug rather than add a new feature, so I think
it should be net tree. But it's fine that if the majority think the net-next is more 
suitable.

> Additionally, it would be great if you could provide in the changelog the
> references to the relevant platform documentation and (even rough) power
> consumption delta estimates.
>