lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon,  5 Sep 2022 11:20:06 +0200
From:   Olliver Schinagl <oliver@...inagl.nl>
To:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Cc:     inux-kernel@...r.kernel.org,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Olliver Schinagl <oliver@...inagl.nl>
Subject: [PATCH 1/2] phy: Move page(d) functions up higher

The page(d) phy function's ought to be close to their non-paged and mmd
variants, as it somewhat logically makes more sense and allows for
future expansion with regards to `phy_*_bits_paged` variants.

Signed-off-by: Olliver Schinagl <oliver@...inagl.nl>
---
 include/linux/phy.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index 87638c55d844..7a2332615b8b 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1153,6 +1153,16 @@ int __phy_modify_mmd(struct phy_device *phydev, int devad, u32 regnum,
 int phy_modify_mmd(struct phy_device *phydev, int devad, u32 regnum,
 		   u16 mask, u16 set);
 
+int phy_save_page(struct phy_device *phydev);
+int phy_select_page(struct phy_device *phydev, int page);
+int phy_restore_page(struct phy_device *phydev, int oldpage, int ret);
+int phy_read_paged(struct phy_device *phydev, int page, u32 regnum);
+int phy_write_paged(struct phy_device *phydev, int page, u32 regnum, u16 val);
+int phy_modify_paged_changed(struct phy_device *phydev, int page, u32 regnum,
+			     u16 mask, u16 set);
+int phy_modify_paged(struct phy_device *phydev, int page, u32 regnum,
+		     u16 mask, u16 set);
+
 /**
  * __phy_set_bits - Convenience function for setting bits in a PHY register
  * @phydev: the phy_device struct
@@ -1411,16 +1421,6 @@ static inline bool phy_is_pseudo_fixed_link(struct phy_device *phydev)
 	return phydev->is_pseudo_fixed_link;
 }
 
-int phy_save_page(struct phy_device *phydev);
-int phy_select_page(struct phy_device *phydev, int page);
-int phy_restore_page(struct phy_device *phydev, int oldpage, int ret);
-int phy_read_paged(struct phy_device *phydev, int page, u32 regnum);
-int phy_write_paged(struct phy_device *phydev, int page, u32 regnum, u16 val);
-int phy_modify_paged_changed(struct phy_device *phydev, int page, u32 regnum,
-			     u16 mask, u16 set);
-int phy_modify_paged(struct phy_device *phydev, int page, u32 regnum,
-		     u16 mask, u16 set);
-
 struct phy_device *phy_device_create(struct mii_bus *bus, int addr, u32 phy_id,
 				     bool is_c45,
 				     struct phy_c45_device_ids *c45_ids);
-- 
2.37.2

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ