lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Sep 2022 16:57:28 +0200 From: Olliver Schinagl <oliver@...inagl.nl> To: Andrew Lunn <andrew@...n.ch> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, "Gustavo A . R . Silva" <gustavoars@...nel.org>, Alexandru Tachici <alexandru.tachici@...log.com>, Hao Chen <chenhao288@...ilicon.com>, Olliver Schinagl <oliver+list@...inagl.nl>, "David S . Miller" <davem@...emloft.net>, Ido Schimmel <idosch@...dia.com>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [PATCH] linkstate: Add macros for link state up/down Hey Andrew, On 06-09-2022 14:18, Andrew Lunn wrote: > On Tue, Sep 06, 2022 at 10:37:54AM +0200, Olliver Schinagl wrote: >> The phylink_link_state.state property can be up or down, via 1 and 0. >> >> The other link state's (speed, duplex) are defined in ethtool.h so lets >> add defines for the link-state there as well so we can use macro's to >> define our up/down states. > Hi Olliver > > The change itself is fine, but we don't add to the API without > users. Please make use of these two new values somewhere, to show they > are really useful. > > Andrew So I've found quite a lot of users, which I suppose is good. I've since decided to turn it into an enum, and refer in the structs as `enum phy_linkstate link:1` (is this even legal?) Would that ok for v2? Olliver
Powered by blists - more mailing lists