netdev - Re: [PATCH iproute2] ip link: add sub-command to view and change DSA master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220906164117.7eiirl4gm6bho2ko@skbuf>
Date:   Tue, 6 Sep 2022 16:41:17 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH iproute2] ip link: add sub-command to view and change DSA
 master

On Tue, Sep 06, 2022 at 08:29:07AM -0700, Stephen Hemminger wrote:
> On Sun,  4 Sep 2022 22:00:25 +0300
> Vladimir Oltean <vladimir.oltean@....com> wrote:
> 
> > Support the "dsa" kind of rtnl_link_ops exported by the kernel, and
> > export reads/writes to IFLA_DSA_MASTER.
> > 
> > Examples:
> > 
> > $ ip link set swp0 type dsa master eth1
> > 
> > $ ip -d link show dev swp0
> >     (...)
> >     dsa master eth0
> > 
> > $ ip -d -j link show swp0
> > [
> > 	{
> > 		"link": "eth1",
> > 		"linkinfo": {
> > 			"info_kind": "dsa",
> > 			"info_data": {
> > 				"master": "eth1"
> > 			}
> > 		},
> > 	}
> > ]
> > 
> > Note that by construction and as shown in the example, the IFLA_LINK
> > reported by a DSA user port is identical to what is reported through
> > IFLA_DSA_MASTER. However IFLA_LINK is not writable, and overloading its
> > meaning to make it writable would clash with other users of IFLA_LINK
> > (vlan etc) for which writing this property does not make sense.
> > 
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> > ---
> 
> Using the term master is an unfortunate choice.
> Although it is common practice in Linux it is not part of any
> current standard and goes against the Linux Foundation non-inclusive
> naming policy.

Concretely, what is it that you propose?