lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Sep 2022 14:58:54 -0700 From: Song Liu <song@...nel.org> To: Toke Høiland-Jørgensen <toke@...hat.com> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Stanislav Fomichev <sdf@...gle.com>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org> Subject: Re: [PATCH bpf-next v2 1/3] dev: Move received_rps counter next to RPS members in softnet data On Mon, Sep 5, 2022 at 12:34 PM Toke Høiland-Jørgensen <toke@...hat.com> wrote: > > Move the received_rps counter value next to the other RPS-related members > in softnet_data. This closes two four-byte holes in the structure, making > room for another pointer in the first two cache lines without bumping the > xmit struct to its own line. > > Reviewed-by: Stanislav Fomichev <sdf@...gle.com> > Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com> Acked-by: Song Liu <song@...nel.org> > --- > include/linux/netdevice.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 1a3cb93c3dcc..fe9aeca2fce9 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -3100,7 +3100,6 @@ struct softnet_data { > /* stats */ > unsigned int processed; > unsigned int time_squeeze; > - unsigned int received_rps; > #ifdef CONFIG_RPS > struct softnet_data *rps_ipi_list; > #endif > @@ -3133,6 +3132,7 @@ struct softnet_data { > unsigned int cpu; > unsigned int input_queue_tail; > #endif > + unsigned int received_rps; > unsigned int dropped; > struct sk_buff_head input_pkt_queue; > struct napi_struct backlog; > -- > 2.37.2 >
Powered by blists - more mailing lists