netdev - Re: [PATCH net-next] net: ftmac100: fix endianness-related issues from 'sparse'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxaTbDoCOA1+23zP@lunn.ch>
Date:   Tue, 6 Sep 2022 02:25:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergei Antonov <saproj@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next] net: ftmac100: fix endianness-related issues
 from 'sparse'

On Fri, Sep 02, 2022 at 02:37:49PM +0300, Sergei Antonov wrote:
> Sparse found a number of endianness-related issues of these kinds:
> 
> .../ftmac100.c:192:32: warning: restricted __le32 degrades to integer
> 
> .../ftmac100.c:208:23: warning: incorrect type in assignment (different base types)
> .../ftmac100.c:208:23:    expected unsigned int rxdes0
> .../ftmac100.c:208:23:    got restricted __le32 [usertype]
> 
> .../ftmac100.c:249:23: warning: invalid assignment: &=
> .../ftmac100.c:249:23:    left side has type unsigned int
> .../ftmac100.c:249:23:    right side has type restricted __le32
> 
> .../ftmac100.c:527:16: warning: cast to restricted __le32
> 
> Change type of some fields from 'unsigned int' to '__le32' to fix it.
> 
> Signed-off-by: Sergei Antonov <saproj@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew