netdev - Re: [PATCH net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cceb17f-8010-209a-a845-3fe9bcd332ab@linux.intel.com>
Date:   Tue, 6 Sep 2022 13:31:43 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     "Kumar, M Chetan" <m.chetan.kumar@...ux.intel.com>
cc:     Netdev <netdev@...r.kernel.org>, kuba@...nel.org,
        davem@...emloft.net, johannes@...solutions.net,
        ryazanov.s.a@...il.com, loic.poulain@...aro.org,
        krishna.c.sudi@...el.com, linuxwwan@...el.com,
        Devegowda Chandrashekar <chandrashekar.devegowda@...el.com>,
        Mishra Soumya Prakash <soumya.prakash.mishra@...el.com>
Subject: Re: [PATCH net-next 4/5] net: wwan: t7xx: Enable devlink based fw
 flashing and coredump collection

On Tue, 6 Sep 2022, Kumar, M Chetan wrote:

> Thank you Ilpo for reviewing patches.
> Will address patch4 & patch5 review comments in v2.

A small correction & one additional item below.

> > > +	read_len = count > skb->len ? skb->len : count;
> > 
> > max_t()

I should have said min_t(), obviously.

> > > +	actual_count = count > txq_mtu ? txq_mtu : count;
> > 
> > max_t()

Here too, min_t().

> > > +		if (read_bytes < 0) {
> > > +			dev_err(port->dev, "status read failed");
> > 
> > Printing "read failed" for -ERESTARTSYS/-EINTR??

Missing \n. There are also other similar dev_err()s, please check them 
through (and perhaps others too besides dev_err()).


-- 
 i.