netdev - Re: [PATCH] net: dsa: microchip: lan937x: fix reference count leak in lan937x_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxnb2MQDevKL2Qmn@lunn.ch>
Date:   Thu, 8 Sep 2022 14:11:04 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sun Ke <sunke32@...wei.com>
Cc:     woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux@...linux.org.uk, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: dsa: microchip: lan937x: fix reference count leak
 in lan937x_mdio_register()

On Thu, Sep 08, 2022 at 12:02:26PM +0800, Sun Ke wrote:
> This node pointer is returned by of_find_compatible_node() with
> refcount incremented in this function. of_node_put() on it before
> exitting this function.
> 
> Fixes: c9cd961c0d43 ("net: dsa: microchip: lan937x: add interrupt support for port phy link")
> Signed-off-by: Sun Ke <sunke32@...wei.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew