[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CABcq3pGKN5ovHC77HZJOK6sjpzsOKStmy4sTmaMq2EMkc0CoQg@mail.gmail.com>
Date: Thu, 8 Sep 2022 23:10:14 +0300
From: Andrew Melnichenko <andrew@...nix.com>
To: David Ahern <dsahern@...nel.org>
Cc: edumazet@...gle.com, netdev@...r.kernel.org,
virtualization@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
jasowang@...hat.com, mst@...hat.com, pabeni@...hat.com,
yoshfuji@...ux-ipv6.org, yan@...nix.com,
yuri.benditovich@...nix.com
Subject: Re: [PATCH v3 1/6] udp: allow header check for dodgy GSO_UDP_L4 packets.
Hi all,
On Thu, Sep 8, 2022 at 3:40 AM David Ahern <dsahern@...nel.org> wrote:
>
> On 9/7/22 6:50 AM, Andrew Melnychenko wrote:
> > diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
> > index 6d1a4bec2614..8e002419b4d5 100644
> > --- a/net/ipv4/udp_offload.c
> > +++ b/net/ipv4/udp_offload.c
> > @@ -387,7 +387,7 @@ static struct sk_buff *udp4_ufo_fragment(struct sk_buff *skb,
> > if (!pskb_may_pull(skb, sizeof(struct udphdr)))
> > goto out;
> >
> > - if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
> > + if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4 && !skb_gso_ok(skb, features | NETIF_F_GSO_ROBUST))
>
> that line needs to be wrapped.
Ok, I'll wrap it.
>
> > return __udp_gso_segment(skb, features, false);
> >
> > mss = skb_shinfo(skb)->gso_size;
>
Powered by blists - more mailing lists