netdev - Re: [PATCH net-next 1/1] igc: ptp: Add 1-step functionality to igc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <C4B215C0-52DA-4400-A6B0-D7736141ED37@timebeat.app>
Date:   Thu, 8 Sep 2022 23:48:48 +0100
From:   Lasse Johnsen <lasse@...ebeat.app>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     netdev@...r.kernel.org, Tony Nguyen <anthony.l.nguyen@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        "Stanton, Kevin B" <kevin.b.stanton@...el.com>,
        Jonathan Lemon <bsd@...com>
Subject: Re: [PATCH net-next 1/1] igc: ptp: Add 1-step functionality to igc
 driver

Hi Richard,

PTP over UDPv4 can run as 2-step concurrently with PTP over Ethernet as 1-step.

Below tshark output from Timebeat in the lab.

All the best,

Lasse
---
[root@...3 ~]#  tshark -i ens1 ether proto 0x88F7 or port 319 or port 320
Running as user "root" and group "root". This could be dangerous.
Capturing on 'ens1'
 ** (tshark:501799) 23:40:12.801240 [Main MESSAGE] -- Capture started.
 ** (tshark:501799) 23:40:12.803786 [Main MESSAGE] -- File: "/var/tmp/wireshark_ens1zTZBYi.pcapng"
    1 0.000000000 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 60 Sync Message
    2 0.000174188 10.101.101.33 → 224.0.1.129  PTPv2 86 Sync Message
    3 0.029971841 HewlettP_1c:42:03 → IEEEI&MS_00:00:00 PTPv2 60 Delay_Req Message
    4 0.030112739 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 68 Delay_Resp Message
    5 0.999391207 10.101.101.33 → 224.0.1.129  PTPv2 86 Sync Message
    6 0.999420338 10.101.101.33 → 224.0.1.129  PTPv2 106 Announce Message
    7 0.999469318 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 60 Sync Message
    8 0.999493068 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 78 Announce Message
    9 0.999519838 10.101.101.33 → 224.0.1.129  PTPv2 86 Follow_Up Message
   10 1.008318061 HewlettP_1c:42:03 → IEEEI&MS_00:00:00 PTPv2 60 Delay_Req Message
   11 1.008417187 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 68 Delay_Resp Message
   12 1.999732615 10.101.101.33 → 224.0.1.129  PTPv2 86 Sync Message
   13 1.999774247 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 60 Sync Message
   14 1.999840628 10.101.101.33 → 224.0.1.129  PTPv2 86 Follow_Up Message
   15 2.008590292 HewlettP_1c:42:03 → IEEEI&MS_00:00:00 PTPv2 60 Delay_Req Message
   16 2.008662394 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 68 Delay_Resp Message
   17 3.000152149 10.101.101.33 → 224.0.1.129  PTPv2 86 Sync Message
   18 3.000183805 10.101.101.33 → 224.0.1.129  PTPv2 106 Announce Message
   19 3.000195810 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 60 Sync Message
   20 3.000216212 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 78 Announce Message
   21 3.000288899 10.101.101.33 → 224.0.1.129  PTPv2 86 Follow_Up Message
   22 3.009000057 HewlettP_1c:42:03 → IEEEI&MS_00:00:00 PTPv2 60 Delay_Req Message
   23 3.009075505 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 68 Delay_Resp Message
   24 4.000147951 10.101.101.33 → 224.0.1.129  PTPv2 86 Sync Message
   25 4.000181728 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 60 Sync Message
   26 4.000248327 10.101.101.33 → 224.0.1.129  PTPv2 86 Follow_Up Message
   27 4.008972302 HewlettP_1c:42:03 → IEEEI&MS_00:00:00 PTPv2 60 Delay_Req Message
   28 4.009030511 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 68 Delay_Resp Message
   29 4.999682198 10.101.101.33 → 224.0.1.129  PTPv2 86 Sync Message
   30 4.999742635 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 60 Sync Message
   31 4.999747433 10.101.101.33 → 224.0.1.129  PTPv2 106 Announce Message
   32 4.999772787 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 78 Announce Message
   33 4.999857708 10.101.101.33 → 224.0.1.129  PTPv2 86 Follow_Up Message
   34 5.008507739 HewlettP_1c:42:03 → IEEEI&MS_00:00:00 PTPv2 60 Delay_Req Message
   35 5.008628544 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 68 Delay_Resp Message
^C   36 5.999954160 10.101.101.33 → 224.0.1.129  PTPv2 86 Sync Message
   37 5.999995843 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 60 Sync Message
   38 6.000067764 10.101.101.33 → 224.0.1.129  PTPv2 86 Follow_Up Message
   39 6.008777977 HewlettP_1c:42:03 → IEEEI&MS_00:00:00 PTPv2 60 Delay_Req Message
   40 6.008864087 IntelCor_91:5e:9d → IEEEI&MS_00:00:00 PTPv2 68 Delay_Resp Message
40 packets captured 

> On 8 Sep 2022, at 23:28, Richard Cochran <richardcochran@...il.com> wrote:
> 
> On Thu, Sep 08, 2022 at 11:18:35PM +0100, Lasse Johnsen wrote:
>> This patch adds 1-step functionality to the igc driver
>> 1-step is only supported in L2 PTP
>> (... as the hardware can update the FCS, but not the UDP checksum on the fly..)
> 
> What happens when user space dials one-step, but in a UDPv4 PTP network?
> 
> Thanks,
> Richard