netdev - Re: [PATCH net-next,v2 01/22] net: sched: act: move global static variable net_id to tc_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9673fd54-a11a-369c-83e4-4a0a4236be74@huawei.com>
Date:   Thu, 8 Sep 2022 14:04:36 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <bpf@...r.kernel.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <jhs@...atatu.com>, <jiri@...nulli.us>, <martin.lau@...ux.dev>,
        <daniel@...earbox.net>, <john.fastabend@...il.com>,
        <ast@...nel.org>, <andrii@...nel.org>, <song@...nel.org>,
        <yhs@...com>, <kpsingh@...nel.org>, <sdf@...gle.com>,
        <haoluo@...gle.com>, <jolsa@...nel.org>, <weiyongjun1@...wei.com>,
        <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next,v2 01/22] net: sched: act: move global static
 variable net_id to tc_action_ops



On 2022/9/8 1:11, Cong Wang wrote:
> On Tue, Sep 06, 2022 at 08:13:25PM +0800, Zhengchao Shao wrote:
>> diff --git a/include/net/act_api.h b/include/net/act_api.h
>> index 9cf6870b526e..86253f8b69a3 100644
>> --- a/include/net/act_api.h
>> +++ b/include/net/act_api.h
>> @@ -113,6 +113,7 @@ struct tc_action_ops {
>>   	enum tca_id  id; /* identifier should match kind */
>>   	size_t	size;
>>   	struct module		*owner;
>> +	unsigned int		net_id;
>>   	int     (*act)(struct sk_buff *, const struct tc_action *,
>>   		       struct tcf_result *); /* called under RCU BH lock*/
>>   	int     (*dump)(struct sk_buff *, struct tc_action *, int, int);
> 
> This _might_ introduce some unnecessary hole in this struct, could you
> check pahole output?
> 
> Thanks.

Hi Wang:
	Thank you for your review. I have send v3. And I'll pay
attention next time.

Zhengchao Shao