netdev - [PATCH] net: ethernet: altera: TSE: fix error return code in altera_tse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220908071306.1015068-1-sunke32@huawei.com>
Date:   Thu, 8 Sep 2022 15:13:06 +0800
From:   Sun Ke <sunke32@...wei.com>
To:     <joyce.ooi@...el.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.or>, <pabeni@...hat.com>,
        <linux@...linux.org.uk>
CC:     <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: [PATCH] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
Signed-off-by: Sun Ke <sunke32@...wei.com>
---
 drivers/net/ethernet/altera/altera_tse_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 89ae6d1623aa..3f3f70542279 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
 				       priv->phy_iface, &alt_tse_phylink_ops);
 	if (IS_ERR(priv->phylink)) {
 		dev_err(&pdev->dev, "failed to create phylink\n");
+		ret = ERR_PTR(priv->phylink);
 		goto err_init_phy;
 	}
 
-- 
2.31.1