netdev - Re: [PATCH -next] net/9p: add __init/__exit annotations to module init/exit funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 20:38:42 +0900
From:   asmadeus@...ewreck.org
To:     Xiu Jianfeng <xiujianfeng@...wei.com>
Cc:     ericvh@...il.com, lucho@...kov.net, linux_oss@...debyte.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, v9fs-developer@...ts.sourceforge.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] net/9p: add __init/__exit annotations to module
 init/exit funcs

Xiu Jianfeng wrote on Fri, Sep 09, 2022 at 06:35:46PM +0800:
> Add missing __init/__exit annotations to module init/exit funcs.

sure, queueing.

FWIW I've checked the others all seem to have it.

> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
> ---
>  net/9p/trans_xen.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
> index 41c57d40efb6..b15c64128c3e 100644
> --- a/net/9p/trans_xen.c
> +++ b/net/9p/trans_xen.c
> @@ -511,7 +511,7 @@ static struct xenbus_driver xen_9pfs_front_driver = {
>  	.otherend_changed = xen_9pfs_front_changed,
>  };
>  
> -static int p9_trans_xen_init(void)
> +static int __init p9_trans_xen_init(void)
>  {
>  	int rc;
>  
> @@ -530,7 +530,7 @@ static int p9_trans_xen_init(void)
>  module_init(p9_trans_xen_init);
>  MODULE_ALIAS_9P("xen");
>  
> -static void p9_trans_xen_exit(void)
> +static void __exit p9_trans_xen_exit(void)
>  {
>  	v9fs_unregister_trans(&p9_xen_trans);
>  	return xenbus_unregister_driver(&xen_9pfs_front_driver);