netdev - Re: [PATCH net-next 1/1] igc: ptp: Add 1-step functionality to igc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 07:21:11 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Lasse Johnsen <lasse@...ebeat.app>
Cc:     netdev@...r.kernel.org, Tony Nguyen <anthony.l.nguyen@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        "Stanton, Kevin B" <kevin.b.stanton@...el.com>,
        Jonathan Lemon <bsd@...com>
Subject: Re: [PATCH net-next 1/1] igc: ptp: Add 1-step functionality to igc
 driver

On Fri, Sep 09, 2022 at 09:51:23AM +0100, Lasse Johnsen wrote:

> So where the driver received an ioctl with tx config option HWTSTAMP_TX_ONESTEP_SYNC it will process 
> skbs not matching the above criteria (including  PTP_CLASS_IPV4) as it would have had the tx config option 
> been HWTSTAMP_TX_ON. This patch does not change the behaviour of the latter in any way.
> 
> Therefore a user space application which has used the HWTSTAMP_TX_ONESTEP_SYNC tx config option
> and is sending UDP messages will as usual receive those messages back in the error queue with 
> hardware timestamps in the normal fashion. (provided of course in the case of this specific driver that
> another tx timestamping operation is not in progress.)

Okay, then I must NAK this patch.  If driver offers one-step and user
enables it, then it should work.

The option, HWTSTAMP_TX_ONESTEP_SYNC, means to apply one-step to any
and all Sync frames, not just layer 2.  The API does not offer a way
to advertise or configure one-step selectively based on network layer.

Thanks,
Richard