netdev - Re: [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee6ac1f4-4c80-948e-4711-7e7843329a16@gmail.com>
Date:   Fri, 9 Sep 2022 10:34:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Mattias Forsblad <mattias.forsblad@...il.com>,
        netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for
 select switches.



On 9/9/2022 1:51 AM, Mattias Forsblad wrote:
> Add RMU enable functionality for some Marvell SOHO switches.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

No need for newline here.

> 
> Signed-off-by: Mattias Forsblad <mattias.forsblad@...il.com>

Just one nit, sorry about that:

[snip]

> index e693154cf803..7ce3c41f6caf 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.h
> +++ b/drivers/net/dsa/mv88e6xxx/chip.h
> @@ -637,6 +637,7 @@ struct mv88e6xxx_ops {
>   
>   	/* Remote Management Unit operations */
>   	int (*rmu_disable)(struct mv88e6xxx_chip *chip);
> +	int (*rmu_enable)(struct mv88e6xxx_chip *chip, int port);

Change the argument name to upstream_port to match the implementation 
for each chip that you are adding?
-- 
Florian