lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Sep 2022 19:54:27 +0100 From: Daniel Golle <daniel@...rotopia.org> To: Lorenzo Bianconi <lorenzo@...nel.org> Cc: netdev@...r.kernel.org, nbd@....name, john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, matthias.bgg@...il.com, linux-mediatek@...ts.infradead.org, lorenzo.bianconi@...hat.com, Bo.Jiao@...iatek.com, sujuan.chen@...iatek.com, ryder.Lee@...iatek.com, evelyn.tsai@...iatek.com, devicetree@...r.kernel.org, robh@...nel.org Subject: Re: [PATCH net-next 08/12] net: ethernet: mtk_eth_soc: add foe info in mtk_soc_data structure On Thu, Sep 08, 2022 at 09:33:42PM +0200, Lorenzo Bianconi wrote: > Introduce foe struct in mtk_soc_data as a container for foe table chip > related definitions. > This is a preliminary patch to enable mt7986 wed support. > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org> > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 70 +++++++- > drivers/net/ethernet/mediatek/mtk_eth_soc.h | 27 ++- > drivers/net/ethernet/mediatek/mtk_ppe.c | 161 ++++++++++-------- > drivers/net/ethernet/mediatek/mtk_ppe.h | 29 ++-- > .../net/ethernet/mediatek/mtk_ppe_offload.c | 34 ++-- > 5 files changed, 208 insertions(+), 113 deletions(-) > > [...] > diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.h b/drivers/net/ethernet/mediatek/mtk_ppe.h > index 6d4c91acd1a5..a364f45edf38 100644 > --- a/drivers/net/ethernet/mediatek/mtk_ppe.h > +++ b/drivers/net/ethernet/mediatek/mtk_ppe.h > @@ -61,6 +61,8 @@ enum { > #define MTK_FOE_VLAN2_WINFO_WCID GENMASK(13, 6) > #define MTK_FOE_VLAN2_WINFO_RING GENMASK(15, 14) > > +#define MTK_FIELD_PREP(mask, val) (((typeof(mask))(val) << __bf_shf(mask)) & (mask)) > +#define MTK_FIELD_GET(mask, val) ((typeof(mask))(((val) & (mask)) >> __bf_shf(mask))) This seems to trigger a compiler bug on ARMv7 (e.g. MT7623) builds: LD .tmp_vmlinux.kallsyms1 arm-openwrt-linux-muslgnueabi-ld: drivers/net/ethernet/mediatek/mtk_ppe.o: in function `mtk_flow_entry_match': /usr/src/lede/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-mediatek_mt7623/linux-5.15.67/drivers/net/ethernet/mediatek/mtk_ppe.c:406: undefined reference to `__ffsdi2' arm-openwrt-linux-muslgnueabi-ld: drivers/net/ethernet/mediatek/mtk_ppe.o: in function `__mtk_foe_entry_commit': /usr/src/lede/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-mediatek_mt7623/linux-5.15.67/drivers/net/ethernet/mediatek/mtk_ppe.c:533: undefined reference to `__ffsdi2' arm-openwrt-linux-muslgnueabi-ld: drivers/net/ethernet/mediatek/mtk_ppe.o: in function `mtk_foe_entry_l2': /usr/src/lede/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-mediatek_mt7623/linux-5.15.67/drivers/net/ethernet/mediatek/mtk_ppe.c:134: undefined reference to `__ffsdi2' arm-openwrt-linux-muslgnueabi-ld: drivers/net/ethernet/mediatek/mtk_ppe.o: in function `mtk_foe_entry_commit_subflow': /usr/src/lede/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-mediatek_mt7623/linux-5.15.67/drivers/net/ethernet/mediatek/mtk_ppe.c:611: undefined reference to `__ffsdi2' arm-openwrt-linux-muslgnueabi-ld: drivers/net/ethernet/mediatek/mtk_ppe.o: in function `mtk_foe_entry_ib2': /usr/src/lede/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-mediatek_mt7623/linux-5.15.67/drivers/net/ethernet/mediatek/mtk_ppe.c:148: undefined reference to `__ffsdi2' arm-openwrt-linux-muslgnueabi-ld: drivers/net/ethernet/mediatek/mtk_ppe.o:/usr/src/lede/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/linux-mediatek_mt7623/linux-5.15.67/drivers/net/ethernet/mediatek/mtk_ppe.c:169: more undefined references to `__ffsdi2' follow > enum { > MTK_FOE_STATE_INVALID, > MTK_FOE_STATE_UNBIND,
Powered by blists - more mailing lists