netdev - Re: [PATCH 1/2] dt-bindings: net: renesas,etheravb: R-Car V3U is R-Car Gen4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 11:58:01 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        netdev <netdev@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: renesas,etheravb: R-Car V3U is
 R-Car Gen4

Hi Krzysztof,

On Fri, Sep 9, 2022 at 11:24 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> On 09/09/2022 11:13, Geert Uytterhoeven wrote:
> > Despite the name, R-Car V3U is the first member of the R-Car Gen4
> > family.  Hence move its compatible value to the R-Car Gen4 section.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

> > --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> > @@ -40,9 +40,13 @@ properties:
> >                - renesas,etheravb-r8a77980     # R-Car V3H
> >                - renesas,etheravb-r8a77990     # R-Car E3
> >                - renesas,etheravb-r8a77995     # R-Car D3
> > -              - renesas,etheravb-r8a779a0     # R-Car V3U
> >            - const: renesas,etheravb-rcar-gen3 # R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,etheravb-r8a779a0     # R-Car V3U
> > +          - const: renesas,etheravb-rcar-gen4 # R-Car Gen4
> > +
>
> Don't you need changes in allOf:if:then section?

No, as there is no logic involving renesas,etheravb-rcar-gen3.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds